tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html - Issue 1967613003: Migrate child element manipulation, innerHTML, classList, attributes,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

Issue 1967613003: Migrate child element manipulation, innerHTML, classList, attributes, (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: white space fix. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/generic_object_view.html ('k') | tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

diff --git a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

index debf307b14d3915e7c8f5ff026004f915b0c5b74..40dad9d420cbeb0b4e4294576f378490497a11ff 100644

--- a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

+++ b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

@@ -138,11 +138,11 @@ tr.exportTo('tr.ui.analysis', function() {

var symbolEl = document.createElement('span');

var symbolColorName;

if (dimension === RowDimension.STACK_FRAME) {

- symbolEl.textContent = LATIN_SMALL_LETTER_F_WITH_HOOK;

+ Polymer.dom(symbolEl).textContent = LATIN_SMALL_LETTER_F_WITH_HOOK;

symbolEl.title = 'Stack frame';

symbolColorName = 'heap_dump_stack_frame';

} else {

- symbolEl.textContent = CIRCLED_LATIN_CAPITAL_LETTER_T;

+ Polymer.dom(symbolEl).textContent = CIRCLED_LATIN_CAPITAL_LETTER_T;

symbolEl.title = 'Object type';

symbolColorName = 'heap_dump_object_type';

}