Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1967613002: Introduce a new ARMSIMDBC configuration. (Closed)

Created:
4 years, 7 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce a new ARMSIMDBC configuration. This allows us to build dart binary with SIMDBC for non-Android ARM devices. We are going to use it to measure performance. BUG=http://dartbug.com/26421 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/43dc5c223de80888614f1a006d2f8c11d9fb94de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M tools/build.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gyp/configurations.gypi View 1 chunk +32 lines, -0 lines 0 comments Download
M tools/utils.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Vyacheslav Egorov (Google)
PTAL
4 years, 7 months ago (2016-05-10 17:18:01 UTC) #2
zra
lgtm Maybe we should drop the 'sim'...
4 years, 7 months ago (2016-05-10 17:26:03 UTC) #3
Vyacheslav Egorov (Google)
4 years, 7 months ago (2016-05-10 18:06:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
43dc5c223de80888614f1a006d2f8c11d9fb94de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698