Issue 19676008: Import windows WebInputEvent factory to content

Issue 19676008: Import windows WebInputEvent factory to content (Closed)

Created:
7 years, 5 months ago by jamesr

Modified:
7 years, 5 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, scottmg, jdduke (slow)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Import windows WebInputEvent factory to content This imports third_party/WebKit/Source/web/win/WebInputEventFactory.cpp to content/browser/renderer_host/input/ and updates content/ to use it instead of the third_party/WebKit version. The code is a straight port and reformat with no (intentional) functional changes or changes in dependencies. BUG=263189 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213318

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove dead code, fix namespace for aurawin #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+513 lines, -24 lines)			Patch
M	content/browser/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	content/browser/renderer_host/input/web_input_event_builders_win.h	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	content/browser/renderer_host/input/web_input_event_builders_win.cc	View	1	1 chunk	+456 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/native_web_keyboard_event_win.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_win.cc	View		5 chunks	+3 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aurawin.cc	View	1	2 chunks	+13 lines, -13 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM https://codereview.chromium.org/19676008/diff/1/content/browser/renderer_host/input/web_input_event_builders_win.h File content/browser/renderer_host/input/web_input_event_builders_win.h (right): https://codereview.chromium.org/19676008/diff/1/content/browser/renderer_host/input/web_input_event_builders_win.h#newcode38 content/browser/renderer_host/input/web_input_event_builders_win.h:38: static void ResetLastClickState(); nit: maybe this could be ...

7 years, 5 months ago (2013-07-23 23:29:10 UTC) #2

jamesr

On 2013/07/23 23:29:10, darin wrote: > LGTM > > https://codereview.chromium.org/19676008/diff/1/content/browser/renderer_host/input/web_input_event_builders_win.h > File content/browser/renderer_host/input/web_input_event_builders_win.h (right): > ...

7 years, 5 months ago (2013-07-24 00:11:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/19676008/9002

7 years, 5 months ago (2013-07-24 00:17:09 UTC) #4

Message was sent while issue was closed.

Change committed as 213318

Expand Messages | Collapse Messages