Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 19676002: Implement top-level getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update pkg status Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart
index d20903260185c99307ace1ff7aa3363ca1162e03..1280c322b34c377aafb1da83226d330c6ea98160 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart
@@ -34,11 +34,11 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {
}
- bool emitClassFields(ClassElement classElement,
- ClassBuilder builder,
- String superName,
- { bool classIsNative: false,
- bool emitStatics: false }) {
+ bool emitFields(ClassElement classElement,
+ ClassBuilder builder,
+ String superName,
+ { bool classIsNative: false,
+ bool emitStatics: false }) {
// Class fields are dynamically generated so they have to be
// emitted using getters and setters instead.
return false;
@@ -54,13 +54,13 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {
// get$d : function() { return this.d; }
// set$d : function(x) { this.d = x; }
List<String> fields = <String>[];
- visitClassFields(classElement, false,
- (Element member,
- String name,
- String accessorName,
- bool needsGetter,
- bool needsSetter,
- bool needsCheckedSetter) {
+ visitFields(classElement, false,
+ (Element member,
+ String name,
+ String accessorName,
+ bool needsGetter,
+ bool needsSetter,
+ bool needsCheckedSetter) {
fields.add(name);
});
String constructorName = namer.safeName(classElement.name.slowToString());

Powered by Google App Engine
This is Rietveld 408576698