Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1967583002: Check bounds of type parameters of function type aliases. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check bounds of type parameters of function type aliases. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bd270935a543d4f1b65f1412356a5f128888ed75

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -31 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +36 lines, -31 lines 1 comment Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-10 16:38:23 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/1967583002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/1967583002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode5233 pkg/analyzer/lib/src/generated/error_verifier.dart:5233: if (element is ClassElement) { Both ClassElement and ...
4 years, 7 months ago (2016-05-10 17:09:28 UTC) #2
scheglov
4 years, 7 months ago (2016-05-10 17:49:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd270935a543d4f1b65f1412356a5f128888ed75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698