[Hotword] Making enabling/disabling the setting enable/disable the hotword extension.

extensions/browser/admin_policy.cc

Index: extensions/browser/admin_policy.cc
diff --git a/extensions/browser/admin_policy.cc b/extensions/browser/admin_policy.cc
index cb948879aa7aea51d6d2b0e4fc564ed9a4129391..d961da1c1783d3dfab86df96eb78932c8d16eeff 100644
--- a/extensions/browser/admin_policy.cc
+++ b/extensions/browser/admin_policy.cc
@@ -16,7 +16,7 @@ bool ManagementPolicyImpl(const extensions::Extension* extension,
                           base::string16* error,
                           bool modifiable_value) {
   bool modifiable =
-      !extensions::Manifest::IsComponentLocation(extension->location()) &&
+      extension->location() != extensions::Manifest::COMPONENT &&

[miket_OOO, 2014/03/12 21:54:46]

Please add a comment indicating that this test implicitly treats COMPONENT and
EXTERNAL_COMPONENT differently. It's not at all apparent from a quick read by
someone who might have forgotten that there are now two kinds of COMPONENT
types.

[rpetterson, 2014/03/12 23:27:32]

Done.

       !extensions::Manifest::IsPolicyLocation(extension->location());
   // Some callers equate "no restriction" to true, others to false.
   if (modifiable)