[Hotword] Making enabling/disabling the setting enable/disable the hotword extension.

chrome/browser/profile_resetter/profile_resetter_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profile_resetter/profile_resetter.h"
 
 #include "base/json/json_string_value_serializer.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_path_override.h"
@@ skipping 599 matching lines @@
       extensions::Manifest::TYPE_EXTENSION,
       false);
   service_->AddExtension(ext3.get());
   scoped_refptr<Extension> ext4 =
       CreateExtension(base::ASCIIToUTF16("example4"),
                       base::FilePath(FILE_PATH_LITERAL("//nonexistent3")),
                       Manifest::EXTERNAL_POLICY_DOWNLOAD,
                       extensions::Manifest::TYPE_EXTENSION,
                       false);
   service_->AddExtension(ext4.get());
+  // External component extensions are the exception as they can be disabled
+  // and should not be re-enabled on reset if they have been disabled.

[battre, 2014/03/14 09:23:15]

Could you explain me how these external component extensions are registered? Are
their locations on the harddrive and update urls hardcoded?

[rpetterson, 2014/03/14 16:31:28]

The update urls are hard coded (most as constants) and the directories on the
hard drive are the same as "normal" extensions. The loading occurs here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

AFAICT the only three extensions/apps which currently use this framework are
hotwording, InAppPayments and the enhanced bookmark experiment.

   scoped_refptr<Extension> ext5 = CreateExtension(
       base::ASCIIToUTF16("example5"),
       base::FilePath(FILE_PATH_LITERAL("//nonexistent4")),
       Manifest::EXTERNAL_COMPONENT,
       extensions::Manifest::TYPE_EXTENSION,
       false);
   service_->AddExtension(ext5.get());
   scoped_refptr<Extension> ext6 = CreateExtension(
       base::ASCIIToUTF16("example6"),
       base::FilePath(FILE_PATH_LITERAL("//nonexistent5")),
       Manifest::EXTERNAL_POLICY,
       extensions::Manifest::TYPE_EXTENSION,
       false);
   service_->AddExtension(ext6.get());
   EXPECT_EQ(6u, service_->extensions()->size());
 
   ResetAndWait(ProfileResetter::EXTENSIONS);
-  EXPECT_EQ(4u, service_->extensions()->size());
+  EXPECT_EQ(3u, service_->extensions()->size());
   EXPECT_FALSE(service_->extensions()->Contains(theme->id()));
   EXPECT_FALSE(service_->extensions()->Contains(ext2->id()));
   EXPECT_TRUE(service_->extensions()->Contains(ext3->id()));
   EXPECT_TRUE(service_->extensions()->Contains(ext4->id()));
-  EXPECT_TRUE(service_->extensions()->Contains(ext5->id()));
+  EXPECT_FALSE(service_->extensions()->Contains(ext5->id()));
   EXPECT_TRUE(service_->extensions()->Contains(ext6->id()));
   EXPECT_TRUE(theme_service->UsingDefaultTheme());
 }
 
 TEST_F(ProfileResetterTest, ResetExtensionsByDisablingNonOrganic) {
   scoped_refptr<Extension> ext2 = CreateExtension(
       base::ASCIIToUTF16("example2"),
       base::FilePath(FILE_PATH_LITERAL("//nonexistent")),
       Manifest::INVALID_LOCATION,
       extensions::Manifest::TYPE_EXTENSION,
@@ skipping 441 matching lines @@
       new ResettableSettingsSnapshot(profile()));
   deleted_snapshot->RequestShortcuts(base::Bind(&FeedbackCapture::Fail,
                                                 base::Unretained(&capture)));
   deleted_snapshot.reset();
   // Running remaining tasks shouldn't trigger the callback to be called as
   // |deleted_snapshot| was deleted before it could run.
   base::MessageLoop::current()->RunUntilIdle();
 }
 
 }  // namespace