Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1967503004: Fix AllocedProxyTest on Mesa (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix AllocedProxyTest on Mesa Mesa is handing us a context that supports MSAA but has 0 as the max number of color samples GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1967503004 Committed: https://skia.googlesource.com/skia/+/d0e36a92de398843cafc3aebef39c863b29c23de

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/ProxyTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 7 months ago (2016-05-10 16:51:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967503004/20001
4 years, 7 months ago (2016-05-10 16:52:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 17:12:16 UTC) #8
bsalomon
lgtm
4 years, 7 months ago (2016-05-10 17:17:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967503004/20001
4 years, 7 months ago (2016-05-10 17:22:36 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:23:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d0e36a92de398843cafc3aebef39c863b29c23de

Powered by Google App Engine
This is Rietveld 408576698