[win] Initialize the app list menu lazily, and allow invalidation.

ui/app_list/views/app_list_main_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_main_view.h"
 
 #include <algorithm>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
@@ skipping 72 matching lines @@
       search_box_view_(NULL),
       contents_view_(NULL) {
   // Starts icon loading early.
   PreloadIcons(pagination_model, anchor);
 
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical,
                                         kInnerPadding,
                                         kInnerPadding,
                                         kInnerPadding));
 
-  search_box_view_ = new SearchBoxView(this, delegate);
+  search_box_view_ = new SearchBoxView(this);

[benwells, 2013/07/23 01:10:43]

Should you update the menu here?

[tapted, 2013/07/23 01:16:47]

I was doing this in patchset 1, but realised it would always be reset again,
because AppListView::InitAsBubble(..) calls OnSigninStatusChanged()

[benwells, 2013/07/23 01:23:26]

I'd prefer not to have distant parts of the code rely on each other like that,
it's the kind of thing that can change easily and cause unexpected problems.

   AddChildView(search_box_view_);
 
   contents_view_ = new ContentsView(this, pagination_model);
   AddChildView(contents_view_);
 
   search_box_view_->set_contents_view(contents_view_);
 
 #if defined(USE_AURA)
   contents_view_->SetPaintToLayer(true);
   contents_view_->SetFillsBoundsOpaquely(false);
@@ skipping 116 matching lines @@
 }
 
 void AppListMainView::InvokeResultAction(SearchResult* result,
                                          int action_index,
                                          int event_flags) {
   if (delegate_)
     delegate_->InvokeSearchResultAction(result, action_index, event_flags);
 }
 
 }  // namespace app_list