Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: Source/bindings/scripts/deprecated_generate_bindings.pl

Issue 19675008: Move btoa() / atob() implementation out of DOMWindow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take Kentaro's feedback into consideration Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/deprecated_code_generator_v8.pm ('k') | Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_generate_bindings.pl
diff --git a/Source/bindings/scripts/deprecated_generate_bindings.pl b/Source/bindings/scripts/deprecated_generate_bindings.pl
index 9e633db6f16014e1c9293630c3b94e170376d577..b61e23bf4ba2e162b08d3fbaf2d872ac74f3f50a 100755
--- a/Source/bindings/scripts/deprecated_generate_bindings.pl
+++ b/Source/bindings/scripts/deprecated_generate_bindings.pl
@@ -133,7 +133,7 @@ foreach my $idlFile (@dependencyIdlFiles) {
# Support for attributes of partial interfaces.
foreach my $attribute (@{$interface->attributes}) {
# Record that this attribute is implemented by $interfaceName.
- $attribute->extendedAttributes->{"ImplementedBy"} = $interfaceName if $interface->isPartial;
+ $attribute->extendedAttributes->{"ImplementedBy"} = $interfaceName unless $interface->extendedAttributes->{"LegacyImplementedInBaseClass"};
# Add interface-wide extended attributes to each attribute.
applyInterfaceExtendedAttributes($interface, $attribute->extendedAttributes);
@@ -144,7 +144,7 @@ foreach my $idlFile (@dependencyIdlFiles) {
# Support for methods of partial interfaces.
foreach my $function (@{$interface->functions}) {
# Record that this method is implemented by $interfaceName.
- $function->extendedAttributes->{"ImplementedBy"} = $interfaceName if $interface->isPartial;
+ $function->extendedAttributes->{"ImplementedBy"} = $interfaceName unless $interface->extendedAttributes->{"LegacyImplementedInBaseClass"};
# Add interface-wide extended attributes to each method.
applyInterfaceExtendedAttributes($interface, $function->extendedAttributes);
@@ -155,7 +155,7 @@ foreach my $idlFile (@dependencyIdlFiles) {
# Support for constants of partial interfaces.
foreach my $constant (@{$interface->constants}) {
# Record that this constant is implemented by $interfaceName.
- $constant->extendedAttributes->{"ImplementedBy"} = $interfaceName if $interface->isPartial;
+ $constant->extendedAttributes->{"ImplementedBy"} = $interfaceName unless $interface->extendedAttributes->{"LegacyImplementedInBaseClass"};
# Add interface-wide extended attributes to each constant.
applyInterfaceExtendedAttributes($interface, $constant->extendedAttributes);
« no previous file with comments | « Source/bindings/scripts/deprecated_code_generator_v8.pm ('k') | Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698