Move btoa() / atob() implementation out of DOMWindow

Source/core/page/DOMWindow.h

 /*
  * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef DOMWindow_h
 #define DOMWindow_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/dom/EventTarget.h"
+#include "core/page/DOMWindowBase64.h"
 #include "core/page/FrameDestructionObserver.h"
 #include "core/platform/Supplementable.h"
 
 #include "wtf/Forward.h"
 
 namespace WebCore {
     class BarProp;
     class CSSRuleList;
     class CSSStyleDeclaration;
     class CanvasRenderingContext2D;
@@ skipping 38 matching lines @@
     class DOMWindowCSS;
 
     struct WindowFeatures;
 
     typedef Vector<RefPtr<MessagePort>, 1> MessagePortArray;
 
     typedef int ExceptionCode;
 
     enum SetLocationLocking { LockHistoryBasedOnGestureState, LockHistoryAndBackForwardList };
 
-    class DOMWindow : public RefCounted<DOMWindow>, public ScriptWrappable, public EventTarget, public FrameDestructionObserver, public Supplementable<DOMWindow> {
+    class DOMWindow : public RefCounted<DOMWindow>, public ScriptWrappable, public EventTarget, public FrameDestructionObserver, public DOMWindowBase64, public Supplementable<DOMWindow> {

[abarth-chromium, 2013/07/18 08:17:14]

Why do we need to subclass?  Can't we just use a partial interface and make
these static functions?

     public:
         static PassRefPtr<DOMWindow> create(Frame* frame) { return adoptRef(new DOMWindow(frame)); }
         virtual ~DOMWindow();
 
         // In some rare cases, we'll re-used a DOMWindow for a new Document. For example,
         // when a script calls window.open("..."), the browser gives JavaScript a window
         // synchronously but kicks off the load in the window asynchronously. Web sites
         // expect that modifications that they make to the window object synchronously
         // won't be blown away when the network load commits. To make that happen, we
         // "securely transition" the existing DOMWindow to the Document that results from
@@ skipping 51 matching lines @@
         PassRefPtr<DOMWindow> open(const String& urlString, const AtomicString& frameName, const String& windowFeaturesString,
             DOMWindow* activeWindow, DOMWindow* firstWindow);
 
         typedef void (*PrepareDialogFunction)(DOMWindow*, void* context);
         void showModalDialog(const String& urlString, const String& dialogFeaturesString,
             DOMWindow* activeWindow, DOMWindow* firstWindow, PrepareDialogFunction, void* functionContext);
 
         void alert(const String& message);
         bool confirm(const String& message);
         String prompt(const String& message, const String& defaultValue);
-        String btoa(const String& stringToEncode, ExceptionCode&);
-        String atob(const String& encodedString, ExceptionCode&);
 
         bool find(const String&, bool caseSensitive, bool backwards, bool wrap, bool wholeWord, bool searchInFrames, bool showDialog) const;
 
         bool offscreenBuffering() const;
 
         int outerHeight() const;
         int outerWidth() const;
         int innerHeight() const;
         int innerWidth() const;
         int screenX() const;
@@ skipping 278 matching lines @@
     }
 
     inline String DOMWindow::defaultStatus() const
     {
         return m_defaultStatus;
     }
 
 } // namespace WebCore
 
 #endif // DOMWindow_h