PasswordController should give up on WebState destruction

PasswordController should give up on WebState destruction

The associated bug has a crash where a WebStateObserverBridge method of
PasswordController dereferences a null pointer. The block where the dereference
happens is:

    if (weakSelf) {
      weakSelf.get()->passwordManager_->OnPasswordFormSubmitted(
          weakSelf.get()->passwordManagerDriver_.get(), form);
    }

It is likely that between the call to
-webState:didSubmitDocumentWithFormNamed:userInitiated: and the execution
of the block the WebState has been destroyed, and therefore also
passwordManager_ and passwordManagerDriver_ nulled.

This CL adds a BOOL to keep track of the destruction of the WebState, allowing
the controller to give up when the WS is destroyed.

R=eugenebut@chromium.org
BUG=608090
Review-Url: https://codereview.chromium.org/1941363002
Cr-Commit-Position: refs/heads/master@{#391511}
(cherry picked from commit 0e96a24352e1ed49716b86177e65b09069ed05a2)

Committed: https://chromium.googlesource.com/chromium/src/+/cd8df42aec73937c97c837299d3d4673b6535d79

[vabr (Chromium), 2016-05-10 07:46:45]

Description was changed from

==========
PasswordController should give up on WebState destruction

The associated bug has a crash where a WebStateObserverBridge method of
PasswordController dereferences a null pointer. The block where the dereference
happens is:

    if (weakSelf) {
      weakSelf.get()->passwordManager_->OnPasswordFormSubmitted(
          weakSelf.get()->passwordManagerDriver_.get(), form);
    }

It is likely that between the call to
-webState:didSubmitDocumentWithFormNamed:userInitiated: and the execution
of the block the WebState has been destroyed, and therefore also
passwordManager_ and passwordManagerDriver_ nulled.

This CL adds a BOOL to keep track of the destruction of the WebState, allowing
the controller to give up when the WS is destroyed.

R=eugenebut@chromium.org
BUG=608090

Review-Url: https://codereview.chromium.org/1941363002
Cr-Commit-Position: refs/heads/master@{#391511}
(cherry picked from commit 0e96a24352e1ed49716b86177e65b09069ed05a2)
==========

to

==========
PasswordController should give up on WebState destruction

The associated bug has a crash where a WebStateObserverBridge method of
PasswordController dereferences a null pointer. The block where the dereference
happens is:

    if (weakSelf) {
      weakSelf.get()->passwordManager_->OnPasswordFormSubmitted(
          weakSelf.get()->passwordManagerDriver_.get(), form);
    }

It is likely that between the call to
-webState:didSubmitDocumentWithFormNamed:userInitiated: and the execution
of the block the WebState has been destroyed, and therefore also
passwordManager_ and passwordManagerDriver_ nulled.

This CL adds a BOOL to keep track of the destruction of the WebState, allowing
the controller to give up when the WS is destroyed.

R=eugenebut@chromium.org
BUG=608090

Review-Url: https://codereview.chromium.org/1941363002
Cr-Commit-Position: refs/heads/master@{#391511}
(cherry picked from commit 0e96a24352e1ed49716b86177e65b09069ed05a2)

Committed:
https://chromium.googlesource.com/chromium/src/+/cd8df42aec73937c97c837299d3d...
==========

[vabr (Chromium), 2016-05-10 07:46:47]

Committed patchset #1 (id:1) manually as
cd8df42aec73937c97c837299d3d4673b6535d79.