Issue 196743008: Revert 169371 "DevTools: defer styles delta calculation to until..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196743008: Revert 169371 "DevTools: defer styles delta calculation to until..." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo

Modified:
6 years, 9 months ago

Reviewers:
pfeldman

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 169371 "DevTools: defer styles delta calculation to until..." This is in order to revert 169354, which caused a crash on ASAN bot. See crbug.com/353257 > DevTools: defer styles delta calculation to until the end of the task. > > BUG=289708 > R=vsevik@chromium.org > > Review URL: https://codereview.chromium.org/201363002 TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169388

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -130 lines)			Patch
M	trunk/LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url.html	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	trunk/LayoutTests/inspector/audits/audits-panel-functional-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/LayoutTests/inspector/elements/styles/add-new-rule-with-style-after-body.html	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	trunk/LayoutTests/inspector/elements/styles/dynamic-style-tag.html	View	2 chunks	+12 lines, -13 lines	0 comments	Download
M	trunk/LayoutTests/inspector/elements/styles/dynamic-style-tag-expected.txt	View	2 chunks	+26 lines, -26 lines	0 comments	Download
M	trunk/LayoutTests/inspector/elements/styles/styles-test.js	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorBaseAgent.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorBaseAgent.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorCSSAgent.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorCSSAgent.cpp	View	6 chunks	+5 lines, -21 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorController.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorController.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorDebuggerAgent.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/devtools/front_end/CSSStyleModel.js	View	6 chunks	+15 lines, -17 lines	0 comments	Download
M	trunk/Source/web/WebDevToolsAgentImpl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/web/WebDevToolsAgentImpl.cpp	View	3 chunks	+5 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r169388.

Expand Messages | Collapse Messages