Source/core/dom/IconURL.h - Issue 196743002: Parse the link element's size attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/IconURL.h

Issue 196743002: Parse the link element's size attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/IconURL.h

diff --git a/Source/core/dom/IconURL.h b/Source/core/dom/IconURL.h

index d35b360d3a522ed16cad4c1be08388cea992de9e..4a6fa233342f2ed634be86a1c7c877465333f7c5 100644

--- a/Source/core/dom/IconURL.h

+++ b/Source/core/dom/IconURL.h

@@ -31,6 +31,7 @@

#ifndef IconURL_h

#define IconURL_h

+#include "platform/geometry/IntSize.h"

#include "platform/weborigin/KURL.h"

namespace WebCore {

@@ -44,7 +45,7 @@ enum IconType {

struct IconURL {

IconType m_iconType;

- String m_sizes;

+ Vector<IntSize> m_sizes;

String m_mimeType;

KURL m_iconURL;

bool m_isDefaultIcon;

@@ -55,7 +56,7 @@ struct IconURL {

{

}

- IconURL(const KURL& url, const String& sizes, const String& mimeType, IconType type)

+ IconURL(const KURL& url, const Vector<IntSize>& sizes, const String& mimeType, IconType type)

: m_iconType(type)

, m_sizes(sizes)

, m_mimeType(mimeType)