Rename NetworkChangeNotifierAutoDetect.Observer.updateActiveNetworkList

Rename NetworkChangeNotifierAutoDetect.Observer.updateActiveNetworkList

Rename it to purgeActiveNetworkList which better reflects its actual
function.  It only purges the list of inactive networks, and does
not add to the list.

R=xunjieli

Committed: https://crrev.com/446fc7377cb12c046a28c77c48cfafc426441e66
Cr-Commit-Position: refs/heads/master@{#398098}

[xunjieli, 2016-05-13 13:49:04]

lgtm

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifier.java (right):

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifier.java:214:
notifyObserversToUpdateActiveNetworkList(activeNetIds);
Maybe also also update the names of notifyObserversToUpdateActiveNetworkList and
nativeNotifyUpdateActiveNetworkList ?

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
(right):

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:505:
* ConnectionType. Only called on Android L and above.
Can we add @TargetApi(Build.VERSION_CODES.LOLLIPOP)? not sure if the annotation
can be applied to interface methods.

[pauljensen, 2016-05-21 01:59:47]

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifier.java (right):

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifier.java:214:
notifyObserversToUpdateActiveNetworkList(activeNetIds);
On 2016/05/13 13:49:04, xunjieli wrote:
> Maybe also also update the names of notifyObserversToUpdateActiveNetworkList
and
> nativeNotifyUpdateActiveNetworkList ?

Done.

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
(right):

https://codereview.chromium.org/1967373003/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:505:
* ConnectionType. Only called on Android L and above.
On 2016/05/13 13:49:04, xunjieli wrote:
> Can we add @TargetApi(Build.VERSION_CODES.LOLLIPOP)? not sure if the
annotation
> can be applied to interface methods.

I feel like that would be unnecessarily exposing implementation details and
leading to unnecessary restrictions.  For example imagine down the road we
figure out a way to do multinetworking on pre-Lollipop devices, then we'd want
these functions to be callable on pre-Lollipop devices.  For the record some
multinetworking can be done on pre-Lollipop devices, it's just extremely clunky.
 Anyhow I feel this is a task for another CL.

[pauljensen, 2016-05-21 02:02:02]

pauljensen@chromium.org changed reviewers:
+ jkarlin@chromium.org, qinmin@chromium.org

[pauljensen, 2016-05-21 02:02:02]

Josh, PTAL @
content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java
Min, PTAL @
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

[jkarlin, 2016-05-23 11:14:11]

content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java
lgtm

[pauljensen, 2016-06-06 12:15:18]

Min, Ping

[qinmin, 2016-06-06 18:08:47]

lgtm

[pauljensen, 2016-06-06 18:15:46]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2016-06-06 18:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1967373003/#ps20001
(title: "expand renames")

[commit-bot: I haz the power, 2016-06-06 18:16:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967373003/20001

[commit-bot: I haz the power, 2016-06-06 19:42:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 19:47:06]

Description was changed from

==========
Rename NetworkChangeNotifierAutoDetect.Observer.updateActiveNetworkList

Rename it to purgeActiveNetworkList which better reflects its actual
function.  It only purges the list of inactive networks, and does
not add to the list.

R=xunjieli
==========

to

==========
Rename NetworkChangeNotifierAutoDetect.Observer.updateActiveNetworkList

Rename it to purgeActiveNetworkList which better reflects its actual
function.  It only purges the list of inactive networks, and does
not add to the list.

R=xunjieli

Committed: https://crrev.com/446fc7377cb12c046a28c77c48cfafc426441e66
Cr-Commit-Position: refs/heads/master@{#398098}
==========

[commit-bot: I haz the power, 2016-06-06 19:47:07]

Patchset 2 (id:??) landed as
https://crrev.com/446fc7377cb12c046a28c77c48cfafc426441e66
Cr-Commit-Position: refs/heads/master@{#398098}