Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 196733002: Add Promises/A+ Compliance Test Suite. (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 8 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Add Promises/A+ Compliance Test Suite. This CL introduces Promises/A+ tests[1]. This CL doesn't contain the test itself: it will be downloaded by test cfg.py. This CL includes some helper JS functions to run the test in d8 shell. [1]: https://github.com/promises-aplus/promises-tests BUG=347095 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19973

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -129 lines) Patch
A + test/promises-aplus/README View 1 1 chunk +29 lines, -0 lines 0 comments Download
A + test/promises-aplus/lib/adapter.js View 1 chunk +12 lines, -15 lines 0 comments Download
A + test/promises-aplus/lib/assert.js View 1 chunk +61 lines, -60 lines 0 comments Download
A + test/promises-aplus/lib/global.js View 1 2 1 chunk +42 lines, -17 lines 0 comments Download
A test/promises-aplus/lib/mocha.js View 1 chunk +264 lines, -0 lines 0 comments Download
A + test/promises-aplus/lib/require.js View 1 chunk +20 lines, -32 lines 0 comments Download
A + test/promises-aplus/lib/run-tests.js View 2 chunks +3 lines, -2 lines 0 comments Download
A + test/promises-aplus/promises-aplus.status View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A test/promises-aplus/testcfg.py View 1 2 1 chunk +148 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
yhirano
6 years, 9 months ago (2014-03-14 12:14:01 UTC) #1
rossberg
LGTM. Thanks!
6 years, 9 months ago (2014-03-14 13:10:51 UTC) #2
rossberg
Committed patchset #3 manually as r19973 (presubmit successful).
6 years, 9 months ago (2014-03-17 10:03:10 UTC) #3
Jakob Kummerow
https://codereview.chromium.org/196733002/diff/40001/test/promises-aplus/testcfg.py File test/promises-aplus/testcfg.py (right): https://codereview.chromium.org/196733002/diff/40001/test/promises-aplus/testcfg.py#newcode88 test/promises-aplus/testcfg.py:88: return 'print("FAIL: fail");' I don't think this is working ...
6 years, 8 months ago (2014-04-24 14:14:53 UTC) #4
yhirano
https://codereview.chromium.org/196733002/diff/40001/test/promises-aplus/testcfg.py File test/promises-aplus/testcfg.py (right): https://codereview.chromium.org/196733002/diff/40001/test/promises-aplus/testcfg.py#newcode88 test/promises-aplus/testcfg.py:88: return 'print("FAIL: fail");' On 2014/04/24 14:14:53, Jakob wrote: > ...
6 years, 8 months ago (2014-04-24 14:35:38 UTC) #5
yhirano
6 years, 8 months ago (2014-04-25 06:31:24 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/258763002/

Powered by Google App Engine
This is Rietveld 408576698