Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1967323002: [MD settings] cleanup   use (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] cleanup   use This CL removes   added while changing i18n-content entries to $i18n. This a correction for CL 1971443003. BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/05cf209ba38a2a1083883bc38f91bed7b6633e69 Cr-Commit-Position: refs/heads/master@{#393131}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/powerwash_dialog.html View 1 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_dialog.html View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-11 23:22:51 UTC) #3
Dan Beam
lgtm with nitx3 https://codereview.chromium.org/1967323002/diff/1/chrome/browser/resources/settings/a11y_page/a11y_page.html File chrome/browser/resources/settings/a11y_page/a11y_page.html (right): https://codereview.chromium.org/1967323002/diff/1/chrome/browser/resources/settings/a11y_page/a11y_page.html#newcode16 chrome/browser/resources/settings/a11y_page/a11y_page.html:16: target="_blank">$i18n{learnMore}</a> you may be able to ...
4 years, 7 months ago (2016-05-11 23:24:45 UTC) #4
dschuyler
https://codereview.chromium.org/1967323002/diff/1/chrome/browser/resources/settings/a11y_page/a11y_page.html File chrome/browser/resources/settings/a11y_page/a11y_page.html (right): https://codereview.chromium.org/1967323002/diff/1/chrome/browser/resources/settings/a11y_page/a11y_page.html#newcode16 chrome/browser/resources/settings/a11y_page/a11y_page.html:16: target="_blank">$i18n{learnMore}</a> On 2016/05/11 23:24:44, Dan Beam wrote: > you ...
4 years, 7 months ago (2016-05-11 23:28:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967323002/20001
4 years, 7 months ago (2016-05-12 00:10:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 01:16:56 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 01:19:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05cf209ba38a2a1083883bc38f91bed7b6633e69
Cr-Commit-Position: refs/heads/master@{#393131}

Powered by Google App Engine
This is Rietveld 408576698