Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Issue 1967303002: Import web-platform-tests@5c527917247fa5e21528f2e742717192976b2fac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
index 277b094d4f77921b45ceac5bb2ab979da937debf..b98bb44705588ebe8afe3fb7a2325230dd3a43e5 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
@@ -89,6 +89,12 @@ from webkitpy.w3c.test_converter import convert_for_webkit
CHANGESET_NOT_AVAILABLE = 'Not Available'
+# Maximum length of import path starting from top of source repository.
+MAX_PATH_LENGTH = 110
+
+# Maximum length of import path starting from top of source repository.
+MAX_PATH_LENGTH = 110
+
_log = logging.getLogger(__name__)
@@ -179,6 +185,7 @@ class TestImporter(object):
def load_changeset(self):
"""Returns the current changeset from mercurial or "Not Available"."""
+ # TODO(qyearsley): Remove this, since mercurial isn't used for w3c repos any more, so this is not applicable.
try:
self.changeset = self.host.executive.run_command(['hg', 'tip']).split('changeset:')[1]
except (OSError, ScriptError):
@@ -344,6 +351,9 @@ class TestImporter(object):
_log.warning('%s not found. Possible error in the test.', orig_filepath)
continue
+ if self.path_too_long(orig_filepath):
+ _log.warning('%s is too long. Skipping.', orig_filepath)
+
new_filepath = os.path.join(new_path, file_to_copy['dest'])
if 'reference_support_info' in file_to_copy.keys() and file_to_copy['reference_support_info'] != {}:
reference_support_info = file_to_copy['reference_support_info']
@@ -403,6 +413,15 @@ class TestImporter(object):
for prefixed_property in sorted(total_prefixed_properties, key=lambda p: total_prefixed_properties[p]):
_log.info(' %s: %s', prefixed_property, total_prefixed_properties[prefixed_property])
+ def path_too_long(self, source_path):
+ """Checks whether a source path is too long to import.
+
+ Args:
+ Absolute path of file to be imported.
+ """
+ path_from_repo_base = os.path.relpath(source_path, self.top_of_repo)
+ return len(path_from_repo_base) > MAX_PATH_LENGTH
+
def setup_destination_directory(self):
""" Creates a destination directory that mirrors that of the source directory """

Powered by Google App Engine
This is Rietveld 408576698