Move webkitplatformsupport_impl and related from glue to child

Move webkitplatformsupport_impl and related from glue to child

Picking up Ananta's change.

Move the webkitplatformsupport_impl.cc/.h files out of webkit\glue to
webkit\child.

This requires moving the following files out of webkit\glue to webkit\child:
1. weburlloader_impl.cc/.h
2. weburlrequest_extradata_impl.cc/.h
3. websocketstreamhandle_impl.cc/.h
4. weburlresponse_extradata_impl.cc/.h
5. websocketstreamhandle_delegate.h
6. ftp_directory_listing_response_delegate.cc/.h
7. multipart_response_delegate.cc/.h
8. multipart_response_delegate_unittest.cc
9. resource_loader_bridge.cc/.h

The following files have been moved to webkit\common:
2. resource_type.cc/.h

Move MemoryUsageKB out of webkit_glue.cc/h to webkit/child/webkit_child_helpers.

I added an include rule to content\common\DEPS to allow including
webkit\child\websocketstreamhandle_delegate.h. This will be removed in a
followup.

TBR=jam@chromium.org, jamesr@chromium.org, jschuh@chromium.org

BUG=237249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212927

[scottmg, 2013-07-20 03:45:09]

jam: content/ and chrome/
jamesr: webkit/

this is only moves and gyp dependency updates, except for webkit_child_helpers
which pulls one function out of webkit_glue.cc.

[jam, 2013-07-21 21:41:01]

On 2013/07/20 03:45:09, scottmg wrote:
> jam: content/ and chrome/
> jamesr: webkit/
> 
> this is only moves and gyp dependency updates, except for webkit_child_helpers
> which pulls one function out of webkit_glue.cc.

resource_loader_bridge.* should be in webkit/child. it's related to resource
loading in a child process. looking at the non-renderer and non-child includes
of it:
content/common/resource_messages.cc: not needed
content/public/common/resource_response.h: not needed
content/public/common/resource_dispatcher_delegate.h: this file just needs to
move to content/public/child. it's paried with resource_dispatcher.h which is in
ocntent/child

[scottmg, 2013-07-22 00:35:22]

On 2013/07/21 21:41:01, jam wrote:
> On 2013/07/20 03:45:09, scottmg wrote:
> > jam: content/ and chrome/
> > jamesr: webkit/
> > 
> > this is only moves and gyp dependency updates, except for
webkit_child_helpers
> > which pulls one function out of webkit_glue.cc.
> 
> resource_loader_bridge.* should be in webkit/child. it's related to resource
> loading in a child process. looking at the non-renderer and non-child includes
> of it:
> content/common/resource_messages.cc: not needed
> content/public/common/resource_response.h: not needed
> content/public/common/resource_dispatcher_delegate.h: this file just needs to
> move to content/public/child. it's paried with resource_dispatcher.h which is
in
> ocntent/child

Ah, thanks. Done.

[jam, 2013-07-22 05:38:22]

lgtm

[jamesr, 2013-07-22 17:36:32]

lgtm

[scottmg, 2013-07-22 17:38:21]

(Had to locally add "+content/public/common" to webkit/child/DEPS because the
line endings in the file were wrong so the tryjobs failed to apply except on
Windows)

[jamesr, 2013-07-22 17:44:17]

https://codereview.chromium.org/19673002/diff/49001/webkit/plugins/webkit_plu...
File webkit/plugins/webkit_plugins.gypi (right):

https://codereview.chromium.org/19673002/diff/49001/webkit/plugins/webkit_plu...
webkit/plugins/webkit_plugins.gypi:44:
'<(DEPTH)/webkit/support/webkit_support.gyp:glue_child',
aren't you already in webkit_support.gyp?

[scottmg, 2013-07-22 17:47:31]

tbr for trivial changes:

joth: android_webview\tools\third_party_files_whitelist.txt
jschuh: chrome\common\automation_messages.h
grt: chrome_frame\plugin_url_request.h

https://codereview.chromium.org/19673002/diff/49001/webkit/plugins/webkit_plu...
File webkit/plugins/webkit_plugins.gypi (right):

https://codereview.chromium.org/19673002/diff/49001/webkit/plugins/webkit_plu...
webkit/plugins/webkit_plugins.gypi:44:
'<(DEPTH)/webkit/support/webkit_support.gyp:glue_child',
On 2013/07/22 17:44:17, jamesr wrote:
> aren't you already in webkit_support.gyp?

Done.

[jschuh, 2013-07-22 17:48:57]

ipc security lgtm. just source path and comment changes

[scottmg, 2013-07-22 18:31:59]

Committed patchset #9 manually as r212927 (presubmit successful).

[joth, 2013-07-22 18:39:34]

lgtm