Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2028)

Unified Diff: appengine/logdog/coordinator/endpoints/services/terminateStream_test.go

Issue 1967273002: LogDog: Implement RegisterPrefix RPC. (Closed) Base URL: https://github.com/luci/luci-go@logdog-butler-register-coordinator-endpoint
Patch Set: Add missing test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/services/terminateStream_test.go
diff --git a/appengine/logdog/coordinator/endpoints/services/terminateStream_test.go b/appengine/logdog/coordinator/endpoints/services/terminateStream_test.go
index 6c532654d61d67711b86a5553369fb843c502ae6..9143fb0291243f64f5fa6bc71454267f64c0314b 100644
--- a/appengine/logdog/coordinator/endpoints/services/terminateStream_test.go
+++ b/appengine/logdog/coordinator/endpoints/services/terminateStream_test.go
@@ -32,10 +32,11 @@ func TestTerminateStream(t *testing.T) {
// Set our archival delays. The project delay is smaller than the service
// delay, so it should be used.
- env.ModServiceConfig(c, func(cfg *svcconfig.Coordinator) {
- cfg.ArchiveTopic = "projects/test/topics/archive"
- cfg.ArchiveSettleDelay = google.NewDuration(10 * time.Second)
- cfg.ArchiveDelayMax = google.NewDuration(24 * time.Hour)
+ env.ModServiceConfig(c, func(cfg *svcconfig.Config) {
+ coord := cfg.Coordinator
+ coord.ArchiveTopic = "projects/test/topics/archive"
+ coord.ArchiveSettleDelay = google.NewDuration(10 * time.Second)
+ coord.ArchiveDelayMax = google.NewDuration(24 * time.Hour)
})
env.ModProjectConfig("proj-foo", func(pcfg *svcconfig.ProjectConfig) {
pcfg.MaxStreamAge = google.NewDuration(time.Hour)
@@ -170,8 +171,8 @@ func TestTerminateStream(t *testing.T) {
})
Convey(`When there is no service or project config delay.`, func() {
- env.ModServiceConfig(c, func(cfg *svcconfig.Coordinator) {
- cfg.ArchiveDelayMax = nil
+ env.ModServiceConfig(c, func(cfg *svcconfig.Config) {
+ cfg.Coordinator.ArchiveDelayMax = nil
})
env.ModProjectConfig("proj-foo", func(pcfg *svcconfig.ProjectConfig) {
pcfg.MaxStreamAge = nil

Powered by Google App Engine
This is Rietveld 408576698