Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1967263002: Launcher icon is misaligned when shelf position is changed to Left/Right (Closed)

Created:
4 years, 7 months ago by Qiang(Joe) Xu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launcher icon is misaligned when shelf position is changed to Left/Right BUG=587931 Committed: https://crrev.com/55bfad47d1daa736f930d9a71aa85f3439a2f0c4 Cr-Commit-Position: refs/heads/master@{#395766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ash/shelf/shelf_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Qiang(Joe) Xu
This is a simple fix for the bug. We probably want to move the layout ...
4 years, 7 months ago (2016-05-11 20:58:49 UTC) #3
Qiang(Joe) Xu
On 2016/05/11 20:58:49, Qiang (Joe) Xu wrote: > This is a simple fix for the ...
4 years, 7 months ago (2016-05-24 22:21:49 UTC) #4
Mr4D (OOO till 08-26)
Sorry slipped through the cracks and I was working on getting the IO demo ready. ...
4 years, 7 months ago (2016-05-24 23:43:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967263002/1
4 years, 7 months ago (2016-05-24 23:47:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 01:21:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 01:23:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55bfad47d1daa736f930d9a71aa85f3439a2f0c4
Cr-Commit-Position: refs/heads/master@{#395766}

Powered by Google App Engine
This is Rietveld 408576698