Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: Source/core/events/EventPath.cpp

Issue 196723014: Replace Element::isMediaElement() with isHTMLMediaElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/EventPath.cpp
diff --git a/Source/core/events/EventPath.cpp b/Source/core/events/EventPath.cpp
index 82ae6d7e4549760c0de73dcfe3655d92026152e0..60c341da992610d7d4c8d482075103a999037557 100644
--- a/Source/core/events/EventPath.cpp
+++ b/Source/core/events/EventPath.cpp
@@ -39,6 +39,7 @@
#include "core/events/MouseEvent.h"
#include "core/events/TouchEvent.h"
#include "core/events/TouchEventContext.h"
+#include "core/html/HTMLMediaElement.h"
#include "core/svg/SVGElementInstance.h"
#include "core/svg/SVGUseElement.h"
@@ -86,7 +87,7 @@ static inline EventDispatchBehavior determineDispatchBehavior(Event* event, Shad
if (Element* element = FullscreenElementStack::currentFullScreenElementFrom(target->toNode()->document())) {
// FIXME: We assume that if the full screen element is a media element that it's
// the video-only full screen. Both here and elsewhere. But that is probably wrong.
- if (element->isMediaElement() && shadowRoot && shadowRoot->host() == element)
+ if (isHTMLMediaElement(element) && shadowRoot && shadowRoot->host() == element)
Inactive 2014/03/13 18:46:24 *element ? To avoid the null check.
return StayInsideShadowDOM;
}

Powered by Google App Engine
This is Rietveld 408576698