Source/core/rendering/shapes/Shape.cpp - Issue 196723010: [CSS Shapes] inset corner radii are not flipped for vertical writing modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/Shape.cpp

Issue 196723010: [CSS Shapes] inset corner radii are not flipped for vertical writing modes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-different-writing-modes-left.html ('K') | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-different-writing-modes-right-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/shapes/Shape.cpp

diff --git a/Source/core/rendering/shapes/Shape.cpp b/Source/core/rendering/shapes/Shape.cpp

index ea562f3e557f13772f8f1679cb0aa14f318488c7..9f74bc9590888b060bb95fdcc5df40d30b0f76f6 100644

--- a/Source/core/rendering/shapes/Shape.cpp

+++ b/Source/core/rendering/shapes/Shape.cpp

@@ -235,11 +235,11 @@ PassOwnPtr<Shape> Shape::createShape(const BasicShape* basicShape, const LayoutS

FloatRect logicalRect = physicalRectToLogical(rect, logicalBoxSize.height(), writingMode);

FloatSize boxSize(boxWidth, boxHeight);

- FloatRoundedRect::Radii cornerRadii(

- floatSizeForLengthSize(inset.topLeftRadius(), boxSize),

- floatSizeForLengthSize(inset.topRightRadius(), boxSize),

- floatSizeForLengthSize(inset.bottomLeftRadius(), boxSize),

- floatSizeForLengthSize(inset.bottomRightRadius(), boxSize));

+ FloatSize topLeftRadius = physicalSizeToLogical(floatSizeForLengthSize(inset.topLeftRadius(), boxSize), writingMode);

+ FloatSize topRightRadius = physicalSizeToLogical(floatSizeForLengthSize(inset.topRightRadius(), boxSize), writingMode);

+ FloatSize bottomLeftRadius = physicalSizeToLogical(floatSizeForLengthSize(inset.bottomLeftRadius(), boxSize), writingMode);

+ FloatSize bottomRightRadius = physicalSizeToLogical(floatSizeForLengthSize(inset.bottomRightRadius(), boxSize), writingMode);

+ FloatRoundedRect::Radii cornerRadii(topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius);

shape = createInsetShape(FloatRoundedRect(logicalRect, cornerRadii));

break;