Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 196723003: Fix for bug 351257: type feedback vector initialization issue. (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
danno, bmeuer
CC:
v8-dev
Visibility:
Public.

Description

Fix for bug 351257: type feedback vector initialization issue. The feedback vector is stored in the shared function info, and there is an effort to reuse it when re-running full code generation as a prelude to creating optimized code. However we shouldn't reuse the vector for lazily compiled methods on first compile, as scoping analysis can change the allocation of vector slots. BUG=351257 LOG=N R=danno@chromium.org, bmeuer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Benedikt, ClusterFuzz found an issue in the type feedback vector implementation. I've profitably reduced ...
6 years, 9 months ago (2014-03-12 12:57:18 UTC) #1
mvstanton
Hi DAnno, you might have a look...
6 years, 9 months ago (2014-03-12 14:07:04 UTC) #2
danno
lgtm
6 years, 9 months ago (2014-03-12 14:33:41 UTC) #3
mvstanton
6 years, 9 months ago (2014-03-12 15:18:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698