Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1967213002: Added reduced WebGL case from Animometer to tough_webgl_cases. (Closed)

Created:
4 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, sullivan, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added reduced WebGL case from Animometer to tough_webgl_cases. Updated links to a few of the earlier test cases. BUG=608576 Committed: https://crrev.com/c293972b740368327c4c6e7f16fc749c451a2998 Cr-Commit-Position: refs/heads/master@{#393115}

Patch Set 1 #

Patch Set 2 : Added SHA1 hashes for new WPR. Deleted intermediate WPRs. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M tools/perf/page_sets/data/tough_webgl_cases.json View 1 1 chunk +14 lines, -11 lines 2 comments Download
A tools/perf/page_sets/data/tough_webgl_cases_004.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_webgl_cases.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Ken Russell (switch to Gerrit)
Ned, Kari, Ethan: please review. I re-recorded this page set locally a couple of times. ...
4 years, 7 months ago (2016-05-11 18:46:23 UTC) #1
Ken Russell (switch to Gerrit)
(Lost the reviewers when I accidentally closed and re-opened the tab -- please see the ...
4 years, 7 months ago (2016-05-11 18:47:03 UTC) #3
aiolos (Not reviewing)
On 2016/05/11 18:46:23, Ken Russell wrote: > Ned, Kari, Ethan: please review. > > I ...
4 years, 7 months ago (2016-05-11 20:51:18 UTC) #6
Ken Russell (switch to Gerrit)
On 2016/05/11 20:51:18, aiolos(slow reviews) wrote: > On 2016/05/11 18:46:23, Ken Russell wrote: > > ...
4 years, 7 months ago (2016-05-11 21:55:39 UTC) #7
Ken Russell (switch to Gerrit)
+vmiura as FYI.
4 years, 7 months ago (2016-05-11 21:55:52 UTC) #8
aiolos (Not reviewing)
lgtm https://codereview.chromium.org/1967213002/diff/20001/tools/perf/page_sets/data/tough_webgl_cases.json File tools/perf/page_sets/data/tough_webgl_cases.json (right): https://codereview.chromium.org/1967213002/diff/20001/tools/perf/page_sets/data/tough_webgl_cases.json#newcode16 tools/perf/page_sets/data/tough_webgl_cases.json:16: "http://montagestudio.com/demos/eco-homes/", Did you get an error message for ...
4 years, 7 months ago (2016-05-11 22:03:04 UTC) #9
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1967213002/diff/20001/tools/perf/page_sets/data/tough_webgl_cases.json File tools/perf/page_sets/data/tough_webgl_cases.json (right): https://codereview.chromium.org/1967213002/diff/20001/tools/perf/page_sets/data/tough_webgl_cases.json#newcode16 tools/perf/page_sets/data/tough_webgl_cases.json:16: "http://montagestudio.com/demos/eco-homes/", On 2016/05/11 22:03:03, aiolos(slow reviews) wrote: > Did ...
4 years, 7 months ago (2016-05-11 22:11:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967213002/20001
4 years, 7 months ago (2016-05-11 22:12:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 00:19:20 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c293972b740368327c4c6e7f16fc749c451a2998 Cr-Commit-Position: refs/heads/master@{#393115}
4 years, 7 months ago (2016-05-12 00:21:59 UTC) #16
vmiura
4 years, 7 months ago (2016-05-16 21:28:28 UTC) #17
Message was sent while issue was closed.
Thanks for adding this test.

It looks to me like with your optimization, the frame_time may now be clipped to
vsync 16.67ms.  May want to up the complexity, so that we can notice any minor
regressions or improvements.

Powered by Google App Engine
This is Rietveld 408576698