Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1967153002: [Android] Run process_resources on aapt or sdk jar change. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Run process_resources on aapt or sdk jar change. Previously, we were only processing resources on aapt or sdk jar _path_ change. This also removes an unrelated debug print statement. BUG=603138 Committed: https://crrev.com/a211f7633c4dc0f2b1fb1c8a40040e84e9568d47 Cr-Commit-Position: refs/heads/master@{#392957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/android/gyp/jar.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/gyp/process_resources.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 7 months ago (2016-05-11 15:22:01 UTC) #2
agrieve
On 2016/05/11 15:22:01, jbudorick wrote: lgtm. Thanks!
4 years, 7 months ago (2016-05-11 15:55:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967153002/1
4 years, 7 months ago (2016-05-11 15:55:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 17:00:16 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:01:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a211f7633c4dc0f2b1fb1c8a40040e84e9568d47
Cr-Commit-Position: refs/heads/master@{#392957}

Powered by Google App Engine
This is Rietveld 408576698