Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1967123002: Add callstats.py run --refresh flag (Closed)

Created:
4 years, 7 months ago by nickie
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add callstats.py run --refresh flag This flag forces the page to (soft) refresh a given number of times for each iteration. The statistics of all refreshes are collected in the same file. R=cbruni@chromium.org, mvstanton@chromium.org BUG= LOG=N Committed: https://crrev.com/8f6556bd1963c1192ebd083ddeb34e867b0a561e Cr-Commit-Position: refs/heads/master@{#36214}

Patch Set 1 #

Patch Set 2 : Add message to separate callstats from different refreshes #

Patch Set 3 : Bug fix for callstats.py json without repeats #

Patch Set 4 : Add exponential timeout in failed retries #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M src/runtime/runtime.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M tools/callstats.py View 1 2 3 4 10 chunks +29 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
nickie
4 years, 7 months ago (2016-05-11 14:11:08 UTC) #1
nickie
So far, it's not easy to distinguish between the statistics from different refreshes. In simple ...
4 years, 7 months ago (2016-05-11 14:22:39 UTC) #2
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-11 14:34:59 UTC) #3
nickie
In the files with the statistics we now have "STATS" lines that mark each refresh. ...
4 years, 7 months ago (2016-05-11 16:39:34 UTC) #4
mvstanton
LGTM, thanks Nikolaus!
4 years, 7 months ago (2016-05-12 14:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967123002/60001
4 years, 7 months ago (2016-05-12 15:14:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/1540) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-12 15:15:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967123002/80001
4 years, 7 months ago (2016-05-12 15:19:18 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-12 15:53:42 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 15:56:00 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8f6556bd1963c1192ebd083ddeb34e867b0a561e
Cr-Commit-Position: refs/heads/master@{#36214}

Powered by Google App Engine
This is Rietveld 408576698