Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1967073003: Make CSSParserToken::operator== perform a full string equality. (Closed)

Created:
4 years, 7 months ago by ikilpatrick
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSParserToken::operator== perform a full string equality. For style diffing in the CSS Paint API, see: https://codereview.chromium.org/1896893004 This prevents setting the same value on a property from causing the paint callback to be invoked. BUG=578252 Committed: https://crrev.com/656644abb2d8fa4770238c06bcd87f4b21697c23 Cr-Commit-Position: refs/heads/master@{#393856}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 1 2 chunks +21 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/css/parser/CSSParserTokenTest.cpp View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ikilpatrick
4 years, 7 months ago (2016-05-11 23:10:38 UTC) #2
Timothy Loh
On 2016/05/11 23:10:38, ikilpatrick wrote: lgtm
4 years, 7 months ago (2016-05-12 07:01:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967073003/40001
4 years, 7 months ago (2016-05-16 16:08:38 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-16 17:25:31 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 17:27:22 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/656644abb2d8fa4770238c06bcd87f4b21697c23
Cr-Commit-Position: refs/heads/master@{#393856}

Powered by Google App Engine
This is Rietveld 408576698