src/wasm/wasm-function-name-table.cc - Issue 1967023004: [wasm] Add UTF-8 validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-function-name-table.cc

Issue 1967023004: [wasm] Add UTF-8 validation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add titzer's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-function-name-table.cc

diff --git a/src/wasm/wasm-function-name-table.cc b/src/wasm/wasm-function-name-table.cc

index 9abcd9b0917364101225ea04b8095fec4c6b8f28..f08270410da6c6b1fa1c2a71535c92529c9de9d2 100644

--- a/src/wasm/wasm-function-name-table.cc

+++ b/src/wasm/wasm-function-name-table.cc

@@ -60,6 +60,9 @@ Handle<Object> GetWasmFunctionNameFromTable(Handle<ByteArray> func_names_array,

: func_names_array->get_int(func_index + 2);

ScopedVector<byte> buffer(next_offset - offset);

func_names_array->copy_out(offset, buffer.start(), next_offset - offset);

+ if (!unibrow::Utf8::Validate(buffer.start(), buffer.length())) {

+ return undefined();

+ }

MaybeHandle<Object> maybe_name =

func_names_array->GetIsolate()->factory()->NewStringFromUtf8(

Vector<const char>::cast(buffer));