[wasm] Add UTF-8 validation

[wasm] Add UTF-8 validation

Names passed for imports and exports are checked during decoding,
leading to errors if they are no valid UTF-8. Function names are not
checked during decode, but rather lead to undefined being returned at
runtime if they are not UTF-8.

We need to do these checks on the Wasm side, since the factory
methods assume to get valid UTF-8 strings.

R=titzer@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/f0523e30467789cbb3689b8023a207d3b5c4873c
Cr-Commit-Position: refs/heads/master@{#36208}

[titzer, 2016-05-12 08:29:14]

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/utf8.h
File src/wasm/utf8.h (right):

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/utf8.h#newcode1
src/wasm/utf8.h:1: // Copyright 2016 the V8 project authors. All rights
reserved.
I think we should put this in src/base, since it's not WASM-specific, though it
is only used in WASM.

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:600: isolate, instance.js_object,
JSFunction::GetName(function), &desc,
I think it's better to pull out the name handle instead of getting it from the
JSFunction here.

[Clemens Hammacher, 2016-05-12 11:21:41]

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/utf8.h
File src/wasm/utf8.h (right):

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/utf8.h#newcode1
src/wasm/utf8.h:1: // Copyright 2016 the V8 project authors. All rights
reserved.
On 2016/05/12 08:29:14, titzer wrote:
> I think we should put this in src/base, since it's not WASM-specific, though
it
> is only used in WASM.

Done.

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/1967023004/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:600: isolate, instance.js_object,
JSFunction::GetName(function), &desc,
On 2016/05/12 08:29:14, titzer wrote:
> I think it's better to pull out the name handle instead of getting it from the
> JSFunction here.

Done.

[titzer, 2016-05-12 11:35:30]

https://codereview.chromium.org/1967023004/diff/40001/src/unicode.cc
File src/unicode.cc (right):

https://codereview.chromium.org/1967023004/diff/40001/src/unicode.cc#newcode311
src/unicode.cc:311: // Preformance optimization: Skip over single-byte values
first.
s/Preformance/Performance/

https://codereview.chromium.org/1967023004/diff/40001/src/wasm/utf8.h
File src/wasm/utf8.h (right):

https://codereview.chromium.org/1967023004/diff/40001/src/wasm/utf8.h#newcode1
src/wasm/utf8.h:1: // Copyright 2016 the V8 project authors. All rights
reserved.
You can drop this file now.

[Clemens Hammacher, 2016-05-12 11:48:27]

https://codereview.chromium.org/1967023004/diff/40001/src/unicode.cc
File src/unicode.cc (right):

https://codereview.chromium.org/1967023004/diff/40001/src/unicode.cc#newcode311
src/unicode.cc:311: // Preformance optimization: Skip over single-byte values
first.
On 2016/05/12 11:35:30, titzer wrote:
> s/Preformance/Performance/

Done.

https://codereview.chromium.org/1967023004/diff/40001/src/wasm/utf8.h
File src/wasm/utf8.h (right):

https://codereview.chromium.org/1967023004/diff/40001/src/wasm/utf8.h#newcode1
src/wasm/utf8.h:1: // Copyright 2016 the V8 project authors. All rights
reserved.
On 2016/05/12 11:35:30, titzer wrote:
> You can drop this file now.

Oh, sorry. Done.

[titzer, 2016-05-12 11:53:03]

lgtm

[clemensh, 2016-05-12 12:07:41]

The CQ bit was checked by clemensh@google.com

[commit-bot: I haz the power, 2016-05-12 12:07:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967023004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967023004/60001

[Yang, 2016-05-12 12:09:31]

src/unicode lgtm.

[commit-bot: I haz the power, 2016-05-12 12:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 12:10:06]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15138)

[Clemens Hammacher, 2016-05-12 12:52:24]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-05-12 12:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1967023004/#ps80001
(title: "rebase on parallel compilation")

[commit-bot: I haz the power, 2016-05-12 12:52:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967023004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967023004/80001

[commit-bot: I haz the power, 2016-05-12 13:01:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-12 13:02:22]

Description was changed from

==========
[wasm] Add UTF-8 validation

Names passed for imports and exports are checked during decoding,
leading to errors if they are no valid UTF-8. Function names are not
checked during decode, but rather lead to undefined being returned at
runtime if they are not UTF-8.

We need to do these checks on the Wasm side, since the factory
methods assume to get valid UTF-8 strings.

R=titzer@chromium.org, yangguo@chromium.org
==========

to

==========
[wasm] Add UTF-8 validation

Names passed for imports and exports are checked during decoding,
leading to errors if they are no valid UTF-8. Function names are not
checked during decode, but rather lead to undefined being returned at
runtime if they are not UTF-8.

We need to do these checks on the Wasm side, since the factory
methods assume to get valid UTF-8 strings.

R=titzer@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/f0523e30467789cbb3689b8023a207d3b5c4873c
Cr-Commit-Position: refs/heads/master@{#36208}
==========

[commit-bot: I haz the power, 2016-05-12 13:02:22]

Patchset 5 (id:??) landed as
https://crrev.com/f0523e30467789cbb3689b8023a207d3b5c4873c
Cr-Commit-Position: refs/heads/master@{#36208}