Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4461)

Unified Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 1967013002: Migrate the site engagement service to use DidFinishNavigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper.h
diff --git a/chrome/browser/engagement/site_engagement_helper.h b/chrome/browser/engagement/site_engagement_helper.h
index 4a56fb0b7f09cb7000b3c9e6c2335657df2fe402..4a331af6c07c3064eaff7e146f64bbf9032961ad 100644
--- a/chrome/browser/engagement/site_engagement_helper.h
+++ b/chrome/browser/engagement/site_engagement_helper.h
@@ -12,6 +12,7 @@
#include "content/public/browser/web_contents_user_data.h"
namespace content {
+class NavigationHandle;
class WebContents;
}
@@ -153,9 +154,7 @@ class SiteEngagementHelper
void RecordMediaPlaying(bool is_hidden);
// content::WebContentsObserver overrides.
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
+ void DidFinishNavigation(content::NavigationHandle* handle) override;
void WasShown() override;
void WasHidden() override;

Powered by Google App Engine
This is Rietveld 408576698