Generate param traits size methods for IPC files in content/ (and traits it depends on).

Generate param traits size methods for IPC files in content/ (and traits it depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to get the content message generator to compile with the size traits.

NOTRY=true

Committed: https://crrev.com/45eceef93a1f6018a9a9a63df84fa0b32a326315
Cr-Commit-Position: refs/heads/master@{#393058}

[jam, 2016-05-11 15:19:07]

Description was changed from

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.
==========

to

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.
==========

[jam, 2016-05-11 15:19:07]

jam@chromium.org changed reviewers:
+ dcheng@chromium.org

[jam, 2016-05-11 15:27:24]

the motivation is https://codereview.chromium.org/1896883002/

https://codereview.chromium.org/1966983003/diff/1/mojo/public/tools/bindings/...
File mojo/public/tools/bindings/mojom.gni (right):

https://codereview.chromium.org/1966983003/diff/1/mojo/public/tools/bindings/...
mojo/public/tools/bindings/mojom.gni:215: inputs = _bindings_configuration_files
fix per rockot so that gen\content\common\mojo_bindings__type_mappings is
regenerated when mojo/public/tools/bindings/chromium_bindings_configuration.gni
changes

[dcheng, 2016-05-11 17:39:12]

What are the implications of GetSize() not matching the actual length of
Write()?

https://codereview.chromium.org/1966983003/diff/1/ui/gfx/ipc/gfx_param_traits.cc
File ui/gfx/ipc/gfx_param_traits.cc (right):

https://codereview.chromium.org/1966983003/diff/1/ui/gfx/ipc/gfx_param_traits...
ui/gfx/ipc/gfx_param_traits.cc:22: s->AddUInt32();
Would it make sense to add a ParamTraits::GetSize specialization for uint32 so
we can just do GetParamSize(s, r.start()) so we can be more consistent about
using GetParamSize() where possible?

https://codereview.chromium.org/1966983003/diff/1/url/ipc/url_param_traits.cc
File url/ipc/url_param_traits.cc (right):

https://codereview.chromium.org/1966983003/diff/1/url/ipc/url_param_traits.cc...
url/ipc/url_param_traits.cc:17: s->AddString(p.possibly_invalid_spec());
Ditto: maybe this should just be GetParamSize(s, p.possibly_invalid_spec())?

[jam, 2016-05-11 17:57:02]

On 2016/05/11 17:39:12, dcheng wrote:
> What are the implications of GetSize() not matching the actual length of
> Write()?

This is only used over mojo. The mojo code needs to preallocate the message, so
if the GetSize results doesn't match what Write() writes it'll CHECK.

https://codereview.chromium.org/1966983003/diff/1/ui/gfx/ipc/gfx_param_traits.cc
File ui/gfx/ipc/gfx_param_traits.cc (right):

https://codereview.chromium.org/1966983003/diff/1/ui/gfx/ipc/gfx_param_traits...
ui/gfx/ipc/gfx_param_traits.cc:22: s->AddUInt32();
On 2016/05/11 17:39:12, dcheng wrote:
> Would it make sense to add a ParamTraits::GetSize specialization for uint32 so
> we can just do GetParamSize(s, r.start()) so we can be more consistent about
> using GetParamSize() where possible?

GetParamSize already works. Switched this and other places. We just haven't been
very consistent, just like with Write/Read, about when to use either.

https://codereview.chromium.org/1966983003/diff/1/url/ipc/url_param_traits.cc
File url/ipc/url_param_traits.cc (right):

https://codereview.chromium.org/1966983003/diff/1/url/ipc/url_param_traits.cc...
url/ipc/url_param_traits.cc:17: s->AddString(p.possibly_invalid_spec());
On 2016/05/11 17:39:12, dcheng wrote:
> Ditto: maybe this should just be GetParamSize(s, p.possibly_invalid_spec())?

Done.

[dcheng, 2016-05-11 18:02:25]

https://codereview.chromium.org/1966983003/diff/2/ipc/ipc_message_utils.cc
File ipc/ipc_message_utils.cc (right):

https://codereview.chromium.org/1966983003/diff/2/ipc/ipc_message_utils.cc#ne...
ipc/ipc_message_utils.cc:698: GetParamSize(sizer, p.GetMemoryObject());size_t
size = 0;
Needs a newline. Shouldn't dummy be the actual result of p.GetSize()?

[jam, 2016-05-11 18:12:21]

https://codereview.chromium.org/1966983003/diff/2/ipc/ipc_message_utils.cc
File ipc/ipc_message_utils.cc (right):

https://codereview.chromium.org/1966983003/diff/2/ipc/ipc_message_utils.cc#ne...
ipc/ipc_message_utils.cc:698: GetParamSize(sizer, p.GetMemoryObject());size_t
size = 0;
On 2016/05/11 18:02:25, dcheng wrote:
> Needs a newline. Shouldn't dummy be the actual result of p.GetSize()?

oops, removed the unnecessary "size_t size = 0".

regarding value of GetSize, that seemed unnecessary. The thing that matters is
we're passing the right type to GetParamSize.

[dcheng, 2016-05-11 18:18:31]

LGTM, you're write, I misread the Write() method.

[dcheng, 2016-05-11 18:18:38]

right***

lskdfjladkjsfd

[jam, 2016-05-11 18:19:22]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-05-11 18:19:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966983003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966983003/20001

[commit-bot: I haz the power, 2016-05-11 18:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 18:28:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-05-11 18:32:22]

btw I fixed some OWNERS files for ipc review

[jam, 2016-05-11 18:32:27]

The CQ bit was checked by jam@chromium.org

[jam, 2016-05-11 18:32:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1966983003/#ps40001
(title: "fix owners")

[commit-bot: I haz the power, 2016-05-11 18:33:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966983003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966983003/40001

[jam, 2016-05-11 19:11:25]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-05-11 19:16:26]

Patchset #4 (id:40001) has been deleted

[jam, 2016-05-11 19:16:32]

The CQ bit was checked by jam@chromium.org

[jam, 2016-05-11 19:16:34]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1966983003/#ps60001
(title: "fix owners")

[commit-bot: I haz the power, 2016-05-11 19:17:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966983003/60001

[jam, 2016-05-11 20:54:07]

Description was changed from

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.
==========

to

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.

NOTRY=true
==========

[jam, 2016-05-11 20:54:33]

sigh, i'm giving up on CQ since the layout tests are triggering and failing
because of flakes and hangs on windows.

[jam, 2016-05-11 20:54:40]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-05-11 20:54:40]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:55:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966983003/60001

[jam, 2016-05-11 20:55:33]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-05-11 20:56:05]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:56:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966983003/60001

[commit-bot: I haz the power, 2016-05-11 21:05:25]

Description was changed from

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.

NOTRY=true
==========

to

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.

NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-11 21:05:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-11 21:17:57]

Description was changed from

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.

NOTRY=true
==========

to

==========
Generate param traits size methods for IPC files in content/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in content/ and below; just enough to
get the content message generator to compile with the size traits.

NOTRY=true

Committed: https://crrev.com/45eceef93a1f6018a9a9a63df84fa0b32a326315
Cr-Commit-Position: refs/heads/master@{#393058}
==========

[commit-bot: I haz the power, 2016-05-11 21:17:59]

Patchset 4 (id:??) landed as
https://crrev.com/45eceef93a1f6018a9a9a63df84fa0b32a326315
Cr-Commit-Position: refs/heads/master@{#393058}