[gn] Refactoring - share common code in source sets

[gn] Refactoring - share common code in source sets

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/49cce9e0a164df33ae1c0737028b02dec7545ded
Cr-Commit-Position: refs/heads/master@{#36166}

[Michael Achenbach, 2016-05-11 09:28:08]

Description was changed from

==========
[gn] Refactoring - share common code in source sets

BUG=
==========

to

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
==========

[Michael Achenbach, 2016-05-11 09:38:15]

Description was changed from

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
==========

to

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-05-11 09:54:11]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org

[Michael Achenbach, 2016-05-11 09:54:12]

PTAL

https://codereview.chromium.org/1966933003/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1966933003/diff/1/BUILD.gn#oldcode1998
BUILD.gn:1998: visibility = [ ":*" ]  # Only targets in this file can depend on
this.
Guess the fuzzer source sets should get the v8_optimized_debug configs too.

https://codereview.chromium.org/1966933003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1966933003/diff/1/BUILD.gn#newcode316
BUILD.gn:316: forward_variables_from(invoker, "*", ["configs"])
I didn't find a way to make the existing configs available in the outer scope,
so that one could use += and -= there. Now, in the outer scope, it's a fresh
variable assigned with =. -= wouldn't work. If we need that we could work around
it by adding a new variable remove_configs and then configs -=
invoker.remove_configs here.

[jochen (gone - plz use gerrit), 2016-05-11 09:59:40]

lgtm

[Michael Achenbach, 2016-05-11 10:16:17]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-05-11 10:16:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966933003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966933003/20001

[commit-bot: I haz the power, 2016-05-11 10:17:45]

Description was changed from

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-11 10:17:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-11 10:19:10]

Description was changed from

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Refactoring - share common code in source sets

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/49cce9e0a164df33ae1c0737028b02dec7545ded
Cr-Commit-Position: refs/heads/master@{#36166}
==========

[commit-bot: I haz the power, 2016-05-11 10:19:11]

Patchset 2 (id:??) landed as
https://crrev.com/49cce9e0a164df33ae1c0737028b02dec7545ded
Cr-Commit-Position: refs/heads/master@{#36166}