mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@26_reader

Patch Set: typeid() is not allowed :/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/string_traits_string_piece.h ('K') | « mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index 5f5d2bef12779d3b31db2fac7040936c28112b67..1e95746e1d429189e492c932f6efc323c22b61f4 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -148,8 +148,6 @@

- method parameters/response parameters: the output is a list of

arguments. #}

{%- macro deserialize(struct, input, output_field_pattern, success) -%}

- DCHECK(!{{input}}.is_null());

{%- for pf in struct.packed.packed_fields_in_ordinal_order %}

{%- set output_field = output_field_pattern|format(pf.field.name) %}

{%- set name = pf.field.name %}