mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h - Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h

Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@26_reader

Patch Set: typeid() is not allowed :/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/string_traits_string_piece.h ('K') | « mojo/public/cpp/bindings/tests/rect_chromium_traits.h ('k') | mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h

diff --git a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h

index fa0fbabea43ef122276241171079ec07e89e2b24..0cfc5e7a520fe76c7127ee00aa9b26f0f1c8bc77 100644

--- a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h

+++ b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h

@@ -12,17 +12,14 @@

#include "base/strings/string_piece.h"

#include "mojo/public/cpp/bindings/struct_traits.h"

#include "mojo/public/cpp/bindings/tests/struct_with_traits_impl.h"

+#include "mojo/public/interfaces/bindings/tests/struct_with_traits.mojom.h"

namespace mojo {

-namespace test {

-class StructWithTraits;

-class StructWithTraits_Reader;

template <>

struct StructTraits<test::StructWithTraits, test::StructWithTraitsImpl> {

// Deserialization to test::StructTraitsImpl.

- static bool Read(test::StructWithTraits_Reader r,

+ static bool Read(test::StructWithTraitsDataView data,

test::StructWithTraitsImpl* out);

// Fields in test::StructWithTraits.