mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl - Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@26_reader

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | url/mojo/origin_struct_traits.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

index e8e92460cd67b41997d02a291f39b2b6df60a53e..94fc78b6a10fccc955526fff70adf782babe206d 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

@@ -1,9 +1,8 @@

{%- import "struct_macros.tmpl" as struct_macros %}

{%- set mojom_type = struct|get_qualified_name_for_kind %}

-{%- set data_type = struct|get_qualified_name_for_kind(internal=True) %}

// static

-bool StructTraits<{{mojom_type}}, {{mojom_type}}Ptr>::ReadFromDataView(

+bool StructTraits<{{mojom_type}}, {{mojom_type}}Ptr>::Read(

{{mojom_type}}DataView input,

{{mojom_type}}Ptr* output) {

bool success = true;