Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: mojo/public/cpp/bindings/lib/serialization_util.h

Issue 1966933002: Mojo C++ bindings: switch the existing usage of StructTraits to use the new data view interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@26_reader
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/tests/rect_blink_traits.h » ('j') | url/mojo/origin_struct_traits.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/serialization_util.h
diff --git a/mojo/public/cpp/bindings/lib/serialization_util.h b/mojo/public/cpp/bindings/lib/serialization_util.h
index 8e926cc5e832803781cf6b8e9a026e4be8ced18f..1b362d17d83f369ce911bd3a19806a289caaf07c 100644
--- a/mojo/public/cpp/bindings/lib/serialization_util.h
+++ b/mojo/public/cpp/bindings/lib/serialization_util.h
@@ -102,20 +102,6 @@ inline void InterfaceDataToPointer(Interface_Data* input,
input->version));
}
-// TODO(yzshen): Unify StructTraits::Read*() methods and remove
-// HasReadFromDataViewMethod.
-template <typename T>
-struct HasReadFromDataViewMethod {
- template <typename U>
- static char Test(decltype(U::ReadFromDataView)*);
- template <typename U>
- static int Test(...);
- static const bool value = sizeof(Test<T>(0)) == sizeof(char);
-
- private:
- EnsureTypeIsComplete<T> check_t_;
-};
-
template <typename T>
struct HasIsNullMethod {
template <typename U>
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/tests/rect_blink_traits.h » ('j') | url/mojo/origin_struct_traits.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698