Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1966853004: Don't compile code for LoadICs if the receiver is primitive (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't compile code for LoadICs if the receiver is primitive BUG=chromium:609134 R=verwaest@chromium.org Committed: https://crrev.com/ced492a6df0359e18ffa07cad95a4fcf5595c318 Cr-Commit-Position: refs/heads/master@{#36168}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/ic/ic.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-11 10:51:14 UTC) #1
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-11 11:00:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966853004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966853004/20001
4 years, 7 months ago (2016-05-11 11:01:23 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 11:27:41 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 11:28:45 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ced492a6df0359e18ffa07cad95a4fcf5595c318
Cr-Commit-Position: refs/heads/master@{#36168}

Powered by Google App Engine
This is Rietveld 408576698