Add indication of camera use on SAML webcam logins

chrome/browser/resources/gaia_auth_host/authenticator.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="saml_handler.js">
 
 /**
  * @fileoverview An UI component to authenciate to Chrome. The component hosts
  * IdP web pages in a webview. A client who is interested in monitoring
  * authentication events should pass a listener object of type
@@ skipping 111 matching lines @@
     assert(this.webview_);
 
     this.email_ = null;
     this.password_ = null;
     this.gaiaId_ = null,
     this.sessionIndex_ = null;
     this.chooseWhatToSync_ = false;
     this.skipForNow_ = false;
     this.authFlow = AuthFlow.DEFAULT;
     this.authDomain = '';
+    this.videoEnabled = false;
     this.idpOrigin_ = null;
     this.continueUrl_ = null;
     this.continueUrlWithoutParams_ = null;
     this.initialFrameUrl_ = null;
     this.reloadUrl_ = null;
     this.trusted_ = true;
     this.oauthCode_ = null;
     this.gapsCookie_ = null;
     this.gapsCookieSent_ = false;
     this.newGapsCookie_ = null;
     this.readyFired_ = false;
 
     this.useEafe_ = false;
     this.clientId_ = null;
 
     this.samlHandler_ = new cr.login.SamlHandler(this.webview_);
     this.confirmPasswordCallback = null;
     this.noPasswordCallback = null;
     this.insecureContentBlockedCallback = null;
     this.samlApiUsedCallback = null;
     this.missingGaiaInfoCallback = null;
     this.needPassword = true;
     this.samlHandler_.addEventListener(
         'insecureContentBlocked',
         this.onInsecureContentBlocked_.bind(this));
     this.samlHandler_.addEventListener(
         'authPageLoaded',
         this.onAuthPageLoaded_.bind(this));
+    this.samlHandler_.addEventListener(
+        'videoEnabled',
+        this.onVideoEnabled_.bind(this));
 
     this.webview_.addEventListener('droplink', this.onDropLink_.bind(this));
     this.webview_.addEventListener(
         'newwindow', this.onNewWindow_.bind(this));
     this.webview_.addEventListener(
         'contentload', this.onContentLoad_.bind(this));
     this.webview_.addEventListener(
         'loadabort', this.onLoadAbort_.bind(this));
     this.webview_.addEventListener(
         'loadstop', this.onLoadStop_.bind(this));
@@ skipping 14 matching lines @@
     window.addEventListener(
         'popstate', this.onPopState_.bind(this), false);
   }
 
   Authenticator.prototype = Object.create(cr.EventTarget.prototype);
 
   /**
    * Reinitializes authentication parameters so that a failed login attempt
    * would not result in an infinite loop.
    */
   Authenticator.prototype.resetStates_ = function() {

[emaxx, 2016/05/17 11:12:23]

You mentioned in the other CL that manual canceling does not reset the
videoEnabled flag.
Looks like this method is the place where it should happen.

Though I don't know how to verify whether any other code path is left uncovered.

[Kevin Cernekee, 2016/05/17 21:31:05]

Done.

     this.email_ = null;
     this.gaiaId_ = null;
     this.password_ = null;
     this.oauthCode_ = null;
     this.gapsCookie_ = null;
     this.gapsCookieSent_ = false;
     this.newGapsCookie_ = null;
     this.readyFired_ = false;
     this.chooseWhatToSync_ = false;
     this.skipForNow_ = false;
@@ skipping 512 matching lines @@
     if (!e.detail.isSAMLPage)
       return;
 
     this.authDomain = this.samlHandler_.authDomain;
     this.authFlow = AuthFlow.SAML;
 
     this.fireReadyEvent_();
   };
 
   /**
+   * Invoked when |samlHandler_| fires 'videoEnabled' event.
+   * @private
+   */
+  Authenticator.prototype.onVideoEnabled_ = function(e) {
+    this.videoEnabled = true;
+  };
+
+  /**
    * Invoked when a link is dropped on the webview.
    * @private
    */
   Authenticator.prototype.onDropLink_ = function(e) {
     this.dispatchEvent(new CustomEvent('dropLink', {detail: e.url}));
   };
 
   /**
    * Invoked when the webview attempts to open a new window.
    * @private
@@ skipping 87 matching lines @@
    * @type {AuthFlow}
    */
   cr.defineProperty(Authenticator, 'authFlow');
 
   /**
    * The domain name of the current auth page.
    * @type {string}
    */
   cr.defineProperty(Authenticator, 'authDomain');
 
+  /**
+   * True if the page has requested media access.
+   * @type {boolean}
+   */
+  cr.defineProperty(Authenticator, 'videoEnabled');
+
   Authenticator.AuthFlow = AuthFlow;
   Authenticator.AuthMode = AuthMode;
   Authenticator.SUPPORTED_PARAMS = SUPPORTED_PARAMS;
 
   return {
     // TODO(guohui, xiyuan): Rename GaiaAuthHost to Authenticator once the old
     // iframe-based flow is deprecated.
     GaiaAuthHost: Authenticator,
     Authenticator: Authenticator
   };
 });