Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1966833002: Dart Timeline improvements (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dart Timeline improvements - [x] Add _getThreadCpuClock to dart:developer. - [x] Report CPU usage for Dart synchronous timeline blocks. - [x] GetEnvironmentValue for 'dart.vm.product' will return "true" or "false" depending on whether or not we are running in product mode. - [x] Early out of Dart timeline calls if we are running in product mode. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/62f91354906bfff34fe7f70a592917c461af46b8

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -19 lines) Patch
M runtime/lib/timeline.cc View 3 chunks +43 lines, -13 lines 0 comments Download
M runtime/lib/timeline.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/developer/timeline.dart View 1 2 10 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 7 months ago (2016-05-10 20:42:02 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/1966833002/diff/20001/sdk/lib/developer/timeline.dart File sdk/lib/developer/timeline.dart (right): https://codereview.chromium.org/1966833002/diff/20001/sdk/lib/developer/timeline.dart#newcode7 sdk/lib/developer/timeline.dart:7: final bool _isProduct = const bool.fromEnvironment("dart.vm.product"); const bool ...
4 years, 7 months ago (2016-05-10 21:20:00 UTC) #4
Cutch
https://codereview.chromium.org/1966833002/diff/20001/sdk/lib/developer/timeline.dart File sdk/lib/developer/timeline.dart (right): https://codereview.chromium.org/1966833002/diff/20001/sdk/lib/developer/timeline.dart#newcode7 sdk/lib/developer/timeline.dart:7: final bool _isProduct = const bool.fromEnvironment("dart.vm.product"); On 2016/05/10 21:20:00, ...
4 years, 7 months ago (2016-05-10 21:30:20 UTC) #5
Cutch
4 years, 7 months ago (2016-05-10 21:31:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
62f91354906bfff34fe7f70a592917c461af46b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698