Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 19668011: Revert 213347 "Use GetDisplayNearestWindow instead of GetDislpa..." (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 213347 "Use GetDisplayNearestWindow instead of GetDislpa..." I suspect this broke WorkspaceManagerTest on Win8 Aura http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/8306 > Use GetDisplayNearestWindow instead of GetDislpaymatching where appropriate > This is correct way to tell on which display > the window is on as a window doesn't overlap two > displays on ash. > > BUG=none > > Review URL: https://chromiumcodereview.appspot.com/19593008 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M trunk/src/ash/wm/drag_window_resizer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/auto_window_management.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/workspace/frame_maximize_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-24 07:15:07 UTC) #1
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-24 07:15:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r213356.

Powered by Google App Engine
This is Rietveld 408576698