Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: buildbot/master/skia_master_scripts/factory.py

Issue 19668009: Move gm-expected to trunk/expectations/gm , and modify scripts that use it. (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: add_master_files Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | buildbot/master/skia_master_scripts/utils.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 """Utility class to build the Skia master BuildFactory's. 6 """Utility class to build the Skia master BuildFactory's.
7 7
8 Based on gclient_factory.py and adds Skia-specific steps.""" 8 Based on gclient_factory.py and adds Skia-specific steps."""
9 9
10 10
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 # and other directories we also wish to check out. 100 # and other directories we also wish to check out.
101 self._gclient_solutions = [gclient_factory.GClientSolution( 101 self._gclient_solutions = [gclient_factory.GClientSolution(
102 svn_url=SKIA_SVN_BASEURL + '/' + build_subdir, name=build_subdir 102 svn_url=SKIA_SVN_BASEURL + '/' + build_subdir, name=build_subdir
103 ).GetSpec()] 103 ).GetSpec()]
104 104
105 if not other_subdirs: 105 if not other_subdirs:
106 other_subdirs = [] 106 other_subdirs = []
107 subdirs_to_checkout = set(other_subdirs) 107 subdirs_to_checkout = set(other_subdirs)
108 108
109 # Trybots need to check out all of these directories. 109 # Trybots need to check out all of these directories.
110 if do_patch_step and not \
111 builder_name.startswith(builder_name_schema.BUILDER_ROLE_BUILD):
112 subdirs_to_checkout.add('gm-expected')
113 for other_subdir in subdirs_to_checkout: 110 for other_subdir in subdirs_to_checkout:
114 self._gclient_solutions.append(gclient_factory.GClientSolution( 111 self._gclient_solutions.append(gclient_factory.GClientSolution(
115 svn_url=SKIA_SVN_BASEURL + '/' + other_subdir, 112 svn_url=SKIA_SVN_BASEURL + '/' + other_subdir,
116 name=other_subdir).GetSpec()) 113 name=other_subdir).GetSpec())
117 114
118 self._deps_target_os = deps_target_os 115 self._deps_target_os = deps_target_os
119 116
120 if gm_image_subdir: 117 if gm_image_subdir:
121 properties['gm_image_subdir'] = gm_image_subdir 118 properties['gm_image_subdir'] = gm_image_subdir
122 119
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 # Perf-only builder. 730 # Perf-only builder.
734 if not self._perf_output_basedir: 731 if not self._perf_output_basedir:
735 raise ValueError( 732 raise ValueError(
736 'BuildPerfOnly requires perf_output_basedir to be defined.') 733 'BuildPerfOnly requires perf_output_basedir to be defined.')
737 if self._configuration != CONFIG_RELEASE: 734 if self._configuration != CONFIG_RELEASE:
738 raise ValueError('BuildPerfOnly should run in %s configuration.' % 735 raise ValueError('BuildPerfOnly should run in %s configuration.' %
739 CONFIG_RELEASE) 736 CONFIG_RELEASE)
740 self.PerfSteps() 737 self.PerfSteps()
741 self.Validate() 738 self.Validate()
742 return self 739 return self
OLDNEW
« no previous file with comments | « no previous file | buildbot/master/skia_master_scripts/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698