Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1966783003: First steps toward AST-based type inference involving closures. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

First steps toward AST-based type inference involving closures. Many corner cases remain to be implemented, and are marked with TODO comments. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f0fd964cd0384d8e9b0e6d849e415e1fe25d929d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -44 lines) Patch
M pkg/analyzer/lib/src/dart/constant/utilities.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 chunk +9 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 11 chunks +82 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 12 chunks +70 lines, -12 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 2 chunks +20 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 8 chunks +30 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 6 chunks +89 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-10 21:28:48 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1966783003/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart File pkg/analyzer/lib/src/summary/summarize_ast.dart (right): https://codereview.chromium.org/1966783003/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart#newcode391 pkg/analyzer/lib/src/summary/summarize_ast.dart:391: var localClosureIndexMap = null; // TODO(paulberry): fix. Do ...
4 years, 7 months ago (2016-05-10 21:47:03 UTC) #3
Paul Berry
https://codereview.chromium.org/1966783003/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart File pkg/analyzer/lib/src/summary/summarize_ast.dart (right): https://codereview.chromium.org/1966783003/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart#newcode391 pkg/analyzer/lib/src/summary/summarize_ast.dart:391: var localClosureIndexMap = null; // TODO(paulberry): fix. On 2016/05/10 ...
4 years, 7 months ago (2016-05-10 22:04:15 UTC) #4
Paul Berry
4 years, 7 months ago (2016-05-10 22:04:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0fd964cd0384d8e9b0e6d849e415e1fe25d929d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698