always emit lazy field if overriding static

always emit lazy field if overriding static

We used to emit an eager field if a static was overriding a static field
in a superclass because this is valid ES6. However, even if the static
field is not synthetic in the superclass, it might still be emitted as a
lazy static. The safest way is just to emit a lazy field for static
overrides always.

fixes #522

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/e133d8477961031c2772346218381f09c6cc6a6e

[Harry Terkelsen, 2016-05-11 17:29:36]

het@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[Jennifer Messerly, 2016-05-11 17:56:10]

jmesserly@google.com changed reviewers:
+ jacobr@google.com

[Jennifer Messerly, 2016-05-11 17:56:11]

Fixing stuff by removing special cases == awesomeness :)

LGTM, with one question to double check SDK is still correct.

https://codereview.chromium.org/1966763004/diff/1/lib/runtime/dart_sdk.js
File lib/runtime/dart_sdk.js (right):

https://codereview.chromium.org/1966763004/diff/1/lib/runtime/dart_sdk.js#new...
lib/runtime/dart_sdk.js:73619: +      return
svg$.SvgElement.abortEvent.forElement(this);
any idea why this change happened? we seem to have switched from HTML to SVG
element here. Not sure what is the right behavior.

[Harry Terkelsen, 2016-05-11 17:59:25]

https://codereview.chromium.org/1966763004/diff/1/lib/runtime/dart_sdk.js
File lib/runtime/dart_sdk.js (right):

https://codereview.chromium.org/1966763004/diff/1/lib/runtime/dart_sdk.js#new...
lib/runtime/dart_sdk.js:73619: +      return
svg$.SvgElement.abortEvent.forElement(this);
On 2016/05/11 17:56:11, John Messerly wrote:
> any idea why this change happened? we seem to have switched from HTML to SVG
> element here. Not sure what is the right behavior.

It's supposed to use it's own static fields for these getters, but they were
commented out and instead used the Element static fields. This is the correct
behavior

[Harry Terkelsen, 2016-05-11 18:09:08]

Description was changed from

==========
always emit lazy field if overriding static

We used to emit an eager field if a static was overriding a static field
in a superclass because this is valid ES6. However, even if the static
field is not synthetic in the superclass, it might still be emitted as a
lazy static. The safest way is just to emit a lazy field for static
overrides always.

fixes #522
==========

to

==========
always emit lazy field if overriding static

We used to emit an eager field if a static was overriding a static field
in a superclass because this is valid ES6. However, even if the static
field is not synthetic in the superclass, it might still be emitted as a
lazy static. The safest way is just to emit a lazy field for static
overrides always.

fixes #522

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/e133d8477961031c277234621838...
==========

[Harry Terkelsen, 2016-05-11 18:09:09]

Committed patchset #2 (id:20001) manually as
e133d8477961031c2772346218381f09c6cc6a6e (presubmit successful).