Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1966743004: Move tracking of ActiveScriptWrappables to V8PerIsolateData. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, kinuko+watch, kouhei+heap_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tracking of ActiveScriptWrappables to V8PerIsolateData. (Active)ScriptWrappables are now traced per isolate by ScriptWrappableVisitor. Keep the set tracking the live ActiveScriptWrappables alongside the isolate instead, moving it out of a static thread-specific persistent set. Releasing that set upon finalization becomes simpler; a more natural home for this per-isolate piece of state. R= BUG= Committed: https://crrev.com/f7da90995fe66485dfce7e407cf90ae2f5e7172f Cr-Commit-Position: refs/heads/master@{#392916}

Patch Set 1 #

Patch Set 2 : lazy creation of map #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -28 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp View 1 chunk +8 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 1 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-11 09:51:40 UTC) #2
jochen (gone - plz use gerrit)
+hlopko
4 years, 7 months ago (2016-05-11 09:56:05 UTC) #4
Marcel Hlopko
lgtm
4 years, 7 months ago (2016-05-11 09:57:39 UTC) #5
haraken
LGTM
4 years, 7 months ago (2016-05-11 10:56:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966743004/20001
4 years, 7 months ago (2016-05-11 13:43:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 14:28:09 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f7da90995fe66485dfce7e407cf90ae2f5e7172f Cr-Commit-Position: refs/heads/master@{#392916}
4 years, 7 months ago (2016-05-11 14:30:10 UTC) #11
esprehn
Can you put more explanation in these patches? This patch has no BUG and no ...
4 years, 7 months ago (2016-05-11 23:40:16 UTC) #12
sof
4 years, 7 months ago (2016-05-12 05:13:55 UTC) #14
Message was sent while issue was closed.
Added a (review) description.

This CL sprang out of https://codereview.chromium.org/1962113003/ (which again
sprang out of observations around
https://codereview.chromium.org/1805843002/#msg36 )

Powered by Google App Engine
This is Rietveld 408576698