Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1966743002: Pin dEQP DEPS to ANGLE's DEPS.chromium. (Closed)

Created:
4 years, 7 months ago by Jamie Madill
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pin dEQP DEPS to ANGLE's DEPS.chromium. This file will manage which dEQP revision Chrome checks out. This allows ANGLE to roll dEQP in the same CL as it updates the build files, which makes testing on the bots possible. BUG=605987 R=iannucci@chromium.org Committed: https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806 Cr-Commit-Position: refs/heads/master@{#392697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M DEPS View 4 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jamie Madill
PTAL Robbie
4 years, 7 months ago (2016-05-10 19:01:11 UTC) #1
iannucci
rs-lgtm (+dpranke/agable for FYI)
4 years, 7 months ago (2016-05-10 19:11:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966743002/1
4 years, 7 months ago (2016-05-10 19:45:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 20:23:43 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806 Cr-Commit-Position: refs/heads/master@{#392697}
4 years, 7 months ago (2016-05-10 20:25:49 UTC) #8
mmoss
4 years, 7 months ago (2016-05-11 15:26:18 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1966243002/ by mmoss@google.com.

The reason for reverting is: Using "recursedeps" broke buildspec creation..

Powered by Google App Engine
This is Rietveld 408576698