third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp - Issue 1966703002: Support includePartialGlyphs=false in Font::offsetForPositionForComplexText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

Issue 1966703002: Support includePartialGlyphs=false in Font::offsetForPositionForComplexText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment as per eae review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultInlineHeaders.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

index 789f39444b886cf2fc76e166eb202a6bee30bd51..389ae19f4b87e7333c23d3686e145ad8b9addb5c 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp

@@ -379,7 +379,7 @@ Vector<CharacterRange> ShapeResultBuffer::individualCharacterRanges(

return ranges;

}

-int ShapeResultBuffer::offsetForPosition(const TextRun& run, float targetX) const

+int ShapeResultBuffer::offsetForPosition(const TextRun& run, float targetX, bool includePartialGlyphs) const

{

unsigned totalOffset;

if (run.rtl()) {

@@ -390,7 +390,7 @@ int ShapeResultBuffer::offsetForPosition(const TextRun& run, float targetX) cons

continue;

totalOffset -= wordResult->numCharacters();

if (targetX >= 0 && targetX <= wordResult->width()) {

- int offsetForWord = wordResult->offsetForPosition(targetX);

+ int offsetForWord = wordResult->offsetForPosition(targetX, includePartialGlyphs);

return totalOffset + offsetForWord;

}

targetX -= wordResult->width();

@@ -400,7 +400,7 @@ int ShapeResultBuffer::offsetForPosition(const TextRun& run, float targetX) cons

for (const auto& wordResult : m_results) {

if (!wordResult)

continue;

- int offsetForWord = wordResult->offsetForPosition(targetX);

+ int offsetForWord = wordResult->offsetForPosition(targetX, includePartialGlyphs);

ASSERT(offsetForWord >= 0);

totalOffset += offsetForWord;

if (targetX >= 0 && targetX <= wordResult->width())