Desktop Capture Picker New UI: Non Mac Structure Change

Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org

Committed: https://crrev.com/5ced272025f70119b5747514bdb112591f36557e
Cr-Commit-Position: refs/heads/master@{#392770}

[qiangchen, 2016-05-10 15:38:29]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

e/Chromium


Unit test


Resolve Comments


Add unittest back


Resolve Comments


File name change


Flag name


Add Flag


Deprecate code


Refactor


Unittest


Use TabbedPane


Merge branch 'PickerNewUI_NonMac_Topo' into PickerNewUI_NonMac_Topo2


Unittest


Unittest


Topology


Topology

BUG=
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org
==========

[qiangchen, 2016-05-10 15:38:30]

qiangchen@chromium.org changed reviewers:
+ msw@chromium.org

[qiangchen, 2016-05-10 16:49:52]

Sorry, I did not anticipated the change would affect Mac, as they share string
resources.

Can you take a look at the fix (Diff between patch 1 and patch 2)?

[msw, 2016-05-10 17:08:30]

lgtm

[qiangchen, 2016-05-10 23:25:51]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2016-05-10 23:25:52]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1966653002/#ps60001
(title: "Merge Rebase Change to New Create File")

[commit-bot: I haz the power, 2016-05-10 23:26:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966653002/60001

[commit-bot: I haz the power, 2016-05-10 23:31:36]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org
==========

[commit-bot: I haz the power, 2016-05-10 23:31:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-10 23:33:07]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org

Committed: https://crrev.com/5ced272025f70119b5747514bdb112591f36557e
Cr-Commit-Position: refs/heads/master@{#392770}
==========

[commit-bot: I haz the power, 2016-05-10 23:33:08]

Patchset 4 (id:??) landed as
https://crrev.com/5ced272025f70119b5747514bdb112591f36557e
Cr-Commit-Position: refs/heads/master@{#392770}