chrome/browser/ui/views/toolbar/toolbar_view.cc - Issue 1966643002: Integrate new MD update menu icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 1966643002: Integrate new MD update menu icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Uses the BadgeType to select the severity-warning icon. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc

index 5341c45188445ca5085799ec7e4f2b3e6ef62487..a42ee715d3becac8fc3eb1a7abb54f7fb661fb2c 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc

@@ -664,7 +664,7 @@ void ToolbarView::UpdateBadgeSeverity(AppMenuBadgeController::BadgeType type,

IDS_ACCNAME_APP_UPGRADE_RECOMMENDED, accname_app);

}

app_menu_button_->SetAccessibleName(accname_app);

- app_menu_button_->SetSeverity(severity, animate);

+ app_menu_button_->SetSeverity(severity, type, animate);

// Keep track of whether we were showing the badge before, so we don't send

// multiple UMA events for example when multiple Chrome windows are open.