Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(113)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: ui/gfx/vector_icons/update_menu_severity_warning.icon
Issue
1966643002
:
Integrate new MD update menu icons. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use a switch statement instead of an if..else ladder
Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/ui/toolbar/app_menu_badge_controller.h
chrome/browser/ui/toolbar/app_menu_badge_controller.cc
chrome/browser/ui/views/toolbar/app_menu_button.h
chrome/browser/ui/views/toolbar/app_menu_button.cc
chrome/browser/ui/views/toolbar/toolbar_view.cc
ui/gfx/BUILD.gn
ui/gfx/vector_icons/update_menu_failed.icon
ui/gfx/vector_icons/update_menu_new_extension.icon
ui/gfx/vector_icons/update_menu_severity_low_medium_high.icon
ui/gfx/vector_icons/update_menu_severity_warning.icon
View unified diff
|
Download patch
« ui/gfx/vector_icons/update_menu_failed.icon
('K') |
« ui/gfx/vector_icons/update_menu_severity_low_medium_high.icon
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
CANVAS_DIMENSIONS, 32,
2
CIRCLE, 16, 16, 16,
3
CLOSE,
4
NEW_PATH,
5
PATH_COLOR_ARGB, 0xFF, 0xFF, 0xFF, 0xFF,
6
MOVE_TO, 18, 16,
7
R_H_LINE_TO, -4,
8
V_LINE_TO, 8,
9
R_H_LINE_TO, 4,
10
R_V_LINE_TO, 8,
11
CLOSE,
12
R_MOVE_TO, 0, 8,
13
R_H_LINE_TO, -4,
14
R_V_LINE_TO, -4,
15
R_H_LINE_TO, 4,
16
R_V_LINE_TO, 4,
17
CLOSE,
18
END
OLD
NEW
« ui/gfx/vector_icons/update_menu_failed.icon
('K') |
« ui/gfx/vector_icons/update_menu_severity_low_medium_high.icon
('k') |
no next file »
|
no next file with comments »
Issue 1966643002: Integrate new MD update menu icons. (Closed)
Created 4 years, 7 months ago by kylix_rd
Modified 4 years, 6 months ago
Reviewers: Evan Stade, msw
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 49
This is Rietveld
408576698
Chromium Code Reviews
Issue 1966643002:
Integrate new MD update menu icons. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master